fix(agent): normalize indentation in code completion postprocess #3361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3263
Fixing wrong indent in inline completion predict solution
Demo
Screen.Recording.2024-11-15.at.09.24.21.mov
Before
Only first line has extra spaces:
exactly one extra space in the line indent
After
exactly one extra space in the line indent
Implementation
Using whether the current indent is even as the judgment basis. If it's even, the prediction doesn't need any extra spaces and the prediction context will be processed accordingly.
Potential risks:
Some users might use odd indent size
Why
This approach is simple and doesn't require adding additional LSP or obtaining the best indent through client operations.
Issue didn't fix
Due to some concern this post-processing not going to fix this situation
All lines in prediction have extra spaces: